-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
types: Regard TypeNewDecimal
as not a hasVariantFieldLength
type. (#21849)
#21960
types: Regard TypeNewDecimal
as not a hasVariantFieldLength
type. (#21849)
#21960
Conversation
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
/run-all-tests |
@LittleFall you're already a collaborator in bot's repo. |
/run-unit-test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/merge |
Sorry @LittleFall, this branch cannot be merged without an approval of release maintainers. |
/merge |
Sorry @eurekaka, this branch's release version is in progress, please contact zhouqiang-cl,shuke987,jebter,you06 for more details. |
/run-all-tests |
cherry-pick #21849 to release-4.0
What problem does this PR solve?
Issue Number: close #21804
Problem Summary:
Tiflash will check whether
Decimal
'sflen
is between 1 and 65. But TiDB enable will push down aDecimal
constant with flen -1 from the environment parameter.What is changed and how it works?
What's Changed:
When creating a
decimal
variable from Parameter, don't set it'sflen
to -1.Other types in
hasVariantFieldLength
don't have this problem.Related changes
Check List
Tests
(will be added to tiflash repo)
test for issue/8644
Side effects
Release note
Wrong precision
.